Skip to content

Commit

Permalink
IB/ehca: Move extern declarations from .c files to .h files
Browse files Browse the repository at this point in the history
Make sure declarations stay in sync with definitions by keeping all 
extern declarations in common .h files.

Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Hoang-Nam Nguyen authored and Roland Dreier committed Jul 29, 2007
1 parent e0f5d99 commit 1655fc2
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions drivers/infiniband/hw/ehca/ehca_classes.h
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ extern int ehca_static_rate;
extern int ehca_port_act_time;
extern int ehca_use_hp_mr;
extern int ehca_scaling_code;
extern int ehca_mr_largepage;

struct ipzu_queue_resp {
u32 qe_size; /* queue entry size */
Expand Down
2 changes: 0 additions & 2 deletions drivers/infiniband/hw/ehca/ehca_mrmw.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ enum ehca_mr_pgsize {
EHCA_MR_PGSIZE16M = 0x1000000L
};

extern int ehca_mr_largepage;

static u32 ehca_encode_hwpage_size(u32 pgsize)
{
u32 idx = 0;
Expand Down
1 change: 0 additions & 1 deletion drivers/infiniband/hw/ehca/ehca_pd.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ int ehca_dealloc_pd(struct ib_pd *pd)
u32 cur_pid = current->tgid;
struct ehca_pd *my_pd = container_of(pd, struct ehca_pd, ib_pd);
int i, leftovers = 0;
extern struct kmem_cache *small_qp_cache;
struct ipz_small_queue_page *page, *tmp;

if (my_pd->ib_pd.uobject && my_pd->ib_pd.uobject->context &&
Expand Down
1 change: 0 additions & 1 deletion drivers/infiniband/hw/ehca/hcp_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,6 @@ u64 hipz_h_register_rpage_mr(const struct ipz_adapter_handle adapter_handle,
const u64 logical_address_of_page,
const u64 count)
{
extern int ehca_debug_level;
u64 ret;

if (unlikely(ehca_debug_level >= 2)) {
Expand Down
2 changes: 2 additions & 0 deletions drivers/infiniband/hw/ehca/ipz_pt_fn.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@
struct ehca_pd;
struct ipz_small_queue_page;

extern struct kmem_cache *small_qp_cache;

/* struct generic ehca page */
struct ipz_page {
u8 entries[EHCA_PAGESIZE];
Expand Down

0 comments on commit 1655fc2

Please sign in to comment.