Skip to content

Commit

Permalink
[PATCH] USB: isp116x-hcd: support only per-port power switching
Browse files Browse the repository at this point in the history
The isp116x chip will now always be in per-port power switching mode. Remove
conf options to set any other mode.

Signed-off-by: Olav Kongas <ok@artecdesign.ee>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Olav Kongas authored and Greg Kroah-Hartman committed Sep 8, 2005
1 parent d4d6286 commit 165c0f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
9 changes: 4 additions & 5 deletions drivers/usb/host/isp116x-hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -1581,11 +1581,10 @@ static int isp116x_start(struct usb_hcd *hcd)

/* ----- Root hub conf */
val = (25 << 24) & RH_A_POTPGT;
/* AN10003_1.pdf recommends NPS to be always 1 */
if (board->no_power_switching)
val |= RH_A_NPS;
if (board->power_switching_mode)
val |= RH_A_PSM;
/* AN10003_1.pdf recommends RH_A_NPS (no power switching) to
be always set. Yet, instead, we request individual port
power switching. */
val |= RH_A_PSM;
isp116x_write_reg32(isp116x, HCRHDESCA, val);
isp116x->rhdesca = isp116x_read_reg32(isp116x, HCRHDESCA);

Expand Down
5 changes: 0 additions & 5 deletions include/linux/usb_isp116x.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ struct isp116x_platform_data {
prevents stopping internal clock, increasing
thereby power consumption in suspended state. */
unsigned remote_wakeup_enable:1;
/* Switch or not to switch (keep always powered) */
unsigned no_power_switching:1;
/* Ganged port power switching (0) or individual port
power switching (1) */
unsigned power_switching_mode:1;
/* Hardware reset set/clear. If implemented, this function must:
if set == 0, deassert chip's HW reset pin
otherwise, assert chip's HW reset pin */
Expand Down

0 comments on commit 165c0f3

Please sign in to comment.