Skip to content

Commit

Permalink
netconsole: Use eth_<foo>_addr instead of memset
Browse files Browse the repository at this point in the history
Use the built-in function instead of memset.

Miscellanea:

Add #include <linux/etherdevice.h>

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joe Perches authored and David S. Miller committed Mar 3, 2015
1 parent 93803b3 commit 1667c94
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/netconsole.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
#include <linux/netpoll.h>
#include <linux/inet.h>
#include <linux/configfs.h>
#include <linux/etherdevice.h>

MODULE_AUTHOR("Maintainer: Matt Mackall <mpm@selenic.com>");
MODULE_DESCRIPTION("Console driver for network interfaces");
Expand Down Expand Up @@ -185,7 +186,7 @@ static struct netconsole_target *alloc_param_target(char *target_config)
nt->np.local_port = 6665;
nt->np.remote_port = 6666;
mutex_init(&nt->mutex);
memset(nt->np.remote_mac, 0xff, ETH_ALEN);
eth_broadcast_addr(nt->np.remote_mac);

/* Parse parameters and setup netpoll */
err = netpoll_parse_options(&nt->np, target_config);
Expand Down Expand Up @@ -604,7 +605,7 @@ static struct config_item *make_netconsole_target(struct config_group *group,
nt->np.local_port = 6665;
nt->np.remote_port = 6666;
mutex_init(&nt->mutex);
memset(nt->np.remote_mac, 0xff, ETH_ALEN);
eth_broadcast_addr(nt->np.remote_mac);

/* Initialize the config_item member */
config_item_init_type_name(&nt->item, name, &netconsole_target_type);
Expand Down

0 comments on commit 1667c94

Please sign in to comment.