Skip to content

Commit

Permalink
staging: comedi: cb_das16_cs: remove thisboard and devpriv macros
Browse files Browse the repository at this point in the history
The 'thisboard' and 'devpriv' macros rely on a local variable having
a specific name and yield pointers derived from that local variable.
Replace the macro with local variables where used. Use the
comedi_board() helper to get the 'thisboard' pointer.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 26, 2012
1 parent ae7df43 commit 16a8cdf
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/staging/comedi/drivers/cb_das16_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ static const struct das16cs_board das16cs_boards[] = {
};

#define n_boards ARRAY_SIZE(das16cs_boards)
#define thisboard ((const struct das16cs_board *)dev->board_ptr)

struct das16cs_private {
struct pcmcia_device *link;
Expand All @@ -94,7 +93,6 @@ struct das16cs_private {
unsigned short status1;
unsigned short status2;
};
#define devpriv ((struct das16cs_private *)dev->private)

static struct pcmcia_device *cur_dev;

Expand All @@ -120,6 +118,7 @@ static int das16cs_ai_rinsn(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
{
struct das16cs_private *devpriv = dev->private;
int i;
int to;
int aref;
Expand Down Expand Up @@ -328,6 +327,7 @@ static int das16cs_ao_winsn(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
{
struct das16cs_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
unsigned short status1;
Expand Down Expand Up @@ -375,6 +375,7 @@ static int das16cs_ao_rinsn(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
{
struct das16cs_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);

Expand Down Expand Up @@ -411,6 +412,7 @@ static int das16cs_dio_insn_config(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
{
struct das16cs_private *devpriv = dev->private;
int chan = CR_CHAN(insn->chanspec);
int bits;

Expand Down Expand Up @@ -478,6 +480,7 @@ static const struct das16cs_board *das16cs_probe(struct comedi_device *dev,
static int das16cs_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
const struct das16cs_board *thisboard;
struct pcmcia_device *link;
struct comedi_subdevice *s;
int ret;
Expand Down Expand Up @@ -509,6 +512,7 @@ static int das16cs_attach(struct comedi_device *dev,
dev->board_ptr = das16cs_probe(dev, link);
if (!dev->board_ptr)
return -EIO;
thisboard = comedi_board(dev);

dev->board_name = thisboard->name;

Expand Down

0 comments on commit 16a8cdf

Please sign in to comment.