Skip to content

Commit

Permalink
staging: dt3155v4l: remove irq_handler from struct dt3155_priv
Browse files Browse the repository at this point in the history
There is no reason to cache the irq_handler in struct dt3155_priv.  Just pass
the function directly in request_irq.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Sep 9, 2011
1 parent f748b65 commit 1707864
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/staging/dt3155v4l/dt3155v4l.c
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,7 @@ dt3155_open(struct file *filp)
/* disable all irqs, clear all irq flags */
iowrite32(FLD_START | FLD_END_EVEN | FLD_END_ODD,
pd->regs + INT_CSR);
pd->irq_handler = dt3155_irq_handler_even;
ret = request_irq(pd->pdev->irq, pd->irq_handler,
ret = request_irq(pd->pdev->irq, dt3155_irq_handler_even,
IRQF_SHARED, DT3155_NAME, pd);
if (ret)
goto err_request_irq;
Expand Down
2 changes: 0 additions & 2 deletions drivers/staging/dt3155v4l/dt3155v4l.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ struct dt3155_stats {
* @q pointer to vb2_queue structure
* @curr_buf: pointer to curren buffer
* @mux: mutex to protect the instance
* @irq_handler: irq handler for the driver
* @dmaq queue for dma buffers
* @lock spinlock for dma queue
* @field_count fields counter
Expand All @@ -199,7 +198,6 @@ struct dt3155_priv {
struct vb2_queue *q;
struct vb2_buffer *curr_buf;
struct mutex mux;
irq_handler_t irq_handler;
struct list_head dmaq;
spinlock_t lock;
unsigned int field_count;
Expand Down

0 comments on commit 1707864

Please sign in to comment.