Skip to content

Commit

Permalink
[BRIDGE]: sysfs locking fix.
Browse files Browse the repository at this point in the history
The stp change code generates "sleeping function called from invalid
context" because rtnl_lock() called with BH disabled. This fixes it by
not acquiring then dropping the bridge lock.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Aug 14, 2007
1 parent 45241a7 commit 1712088
Showing 1 changed file with 15 additions and 9 deletions.
24 changes: 15 additions & 9 deletions net/bridge/br_sysfs_br.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,20 +147,26 @@ static ssize_t show_stp_state(struct device *d,
return sprintf(buf, "%d\n", br->stp_enabled);
}

static void set_stp_state(struct net_bridge *br, unsigned long val)
{
rtnl_lock();
spin_unlock_bh(&br->lock);
br_stp_set_enabled(br, val);
spin_lock_bh(&br->lock);
rtnl_unlock();
}

static ssize_t store_stp_state(struct device *d,
struct device_attribute *attr, const char *buf,
size_t len)
{
return store_bridge_parm(d, buf, len, set_stp_state);
struct net_bridge *br = to_bridge(d);
char *endp;
unsigned long val;

if (!capable(CAP_NET_ADMIN))
return -EPERM;

val = simple_strtoul(buf, &endp, 0);
if (endp == buf)
return -EINVAL;

rtnl_lock();
br_stp_set_enabled(br, val);
rtnl_unlock();

}
static DEVICE_ATTR(stp_state, S_IRUGO | S_IWUSR, show_stp_state,
store_stp_state);
Expand Down

0 comments on commit 1712088

Please sign in to comment.