Skip to content

Commit

Permalink
NFC: Fix bitops usage in LLCP
Browse files Browse the repository at this point in the history
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Samuel Ortiz authored and John W. Linville committed Mar 6, 2012
1 parent 53a0ac2 commit 1762c17
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions net/nfc/llcp/llcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ u8 nfc_llcp_get_sdp_ssap(struct nfc_llcp_local *local,
return LLCP_SAP_MAX;
}

set_bit(BIT(ssap), &local->local_wks);
set_bit(ssap, &local->local_wks);
mutex_unlock(&local->sdp_lock);

return ssap;
Expand All @@ -195,25 +195,25 @@ u8 nfc_llcp_get_sdp_ssap(struct nfc_llcp_local *local,

pr_debug("SDP ssap %d\n", LLCP_WKS_NUM_SAP + ssap);

set_bit(BIT(ssap), &local->local_sdp);
set_bit(ssap, &local->local_sdp);
mutex_unlock(&local->sdp_lock);

return LLCP_WKS_NUM_SAP + ssap;

} else if (sock->ssap != 0) {
if (sock->ssap < LLCP_WKS_NUM_SAP) {
if (!(local->local_wks & BIT(sock->ssap))) {
set_bit(BIT(sock->ssap), &local->local_wks);
if (!test_bit(sock->ssap, &local->local_wks)) {
set_bit(sock->ssap, &local->local_wks);
mutex_unlock(&local->sdp_lock);

return sock->ssap;
}

} else if (sock->ssap < LLCP_SDP_NUM_SAP) {
if (!(local->local_sdp &
BIT(sock->ssap - LLCP_WKS_NUM_SAP))) {
set_bit(BIT(sock->ssap - LLCP_WKS_NUM_SAP),
&local->local_sdp);
if (!test_bit(sock->ssap - LLCP_WKS_NUM_SAP,
&local->local_sdp)) {
set_bit(sock->ssap - LLCP_WKS_NUM_SAP,
&local->local_sdp);
mutex_unlock(&local->sdp_lock);

return sock->ssap;
Expand All @@ -238,7 +238,7 @@ u8 nfc_llcp_get_local_ssap(struct nfc_llcp_local *local)
return LLCP_SAP_MAX;
}

set_bit(BIT(local_ssap), &local->local_sap);
set_bit(local_ssap, &local->local_sap);

mutex_unlock(&local->sdp_lock);

Expand All @@ -265,7 +265,7 @@ void nfc_llcp_put_ssap(struct nfc_llcp_local *local, u8 ssap)

mutex_lock(&local->sdp_lock);

clear_bit(1 << local_ssap, sdp);
clear_bit(local_ssap, sdp);

mutex_unlock(&local->sdp_lock);
}
Expand Down

0 comments on commit 1762c17

Please sign in to comment.