Skip to content

Commit

Permalink
mtd: maps: Remove BUS_ID_SIZE from integrator_flash
Browse files Browse the repository at this point in the history
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Tested-by: Catalin Marinas <catalin.marinas@arm.com>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Jun 24, 2009
1 parent 4839641 commit 17659c6
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions drivers/mtd/maps/integrator-flash.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,8 @@
#include <mach/hardware.h>
#include <asm/system.h>

#define SUBDEV_NAME_SIZE (BUS_ID_SIZE + 2)

struct armflash_subdev_info {
char name[SUBDEV_NAME_SIZE];
char *name;
struct mtd_info *mtd;
struct map_info map;
struct flash_platform_data *plat;
Expand Down Expand Up @@ -134,6 +132,8 @@ static void armflash_subdev_remove(struct armflash_subdev_info *subdev)
map_destroy(subdev->mtd);
if (subdev->map.virt)
iounmap(subdev->map.virt);
kfree(subdev->name);
subdev->name = NULL;
release_mem_region(subdev->map.phys, subdev->map.size);
}

Expand Down Expand Up @@ -177,16 +177,22 @@ static int armflash_probe(struct platform_device *dev)

if (nr == 1)
/* No MTD concatenation, just use the default name */
snprintf(subdev->name, SUBDEV_NAME_SIZE, "%s",
dev_name(&dev->dev));
subdev->name = kstrdup(dev_name(&dev->dev), GFP_KERNEL);
else
snprintf(subdev->name, SUBDEV_NAME_SIZE, "%s-%d",
dev_name(&dev->dev), i);
subdev->name = kasprintf(GFP_KERNEL, "%s-%d",
dev_name(&dev->dev), i);
if (!subdev->name) {
err = -ENOMEM;
break;
}
subdev->plat = plat;

err = armflash_subdev_probe(subdev, res);
if (err)
if (err) {
kfree(subdev->name);
subdev->name = NULL;
break;
}
}
info->nr_subdev = i;

Expand Down

0 comments on commit 17659c6

Please sign in to comment.