Skip to content

Commit

Permalink
Input: ucb1400_ts - use schedule_timeout_uninterruptible
Browse files Browse the repository at this point in the history
Given that the code is not checking for signals it should
use uninterruptible sleep.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
Acked-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Rene Herman authored and Dmitry Torokhov committed Sep 26, 2007
1 parent 2f9d282 commit 1788180
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/input/touchscreen/ucb1400_ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
if (val & UCB_ADC_DAT_VALID)
break;
/* yield to other processes */
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
schedule_timeout_uninterruptible(1);
}

return UCB_ADC_DAT_VALUE(val);
Expand Down

0 comments on commit 1788180

Please sign in to comment.