Skip to content

Commit

Permalink
sched: do not normalize kernel threads via SysRq-N
Browse files Browse the repository at this point in the history
do not normalize kernel threads via SysRq-N: the migration threads,
softlockup threads, etc. might be essential for the system to
function properly. So only zap user tasks.

pointed out by Andi Kleen.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Oct 15, 2007
1 parent 1666703 commit 178be79
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,15 +365,6 @@ static inline int cpu_of(struct rq *rq)
#endif
}

static inline int is_migration_thread(struct task_struct *p, struct rq *rq)
{
#ifdef CONFIG_SMP
return p == rq->migration_thread;
#else
return 0;
#endif
}

/*
* Update the per-runqueue clock, as finegrained as the platform can give
* us, but without assuming monotonicity, etc.:
Expand Down Expand Up @@ -6563,6 +6554,12 @@ void normalize_rt_tasks(void)

read_lock_irq(&tasklist_lock);
do_each_thread(g, p) {
/*
* Only normalize user tasks:
*/
if (!p->mm)
continue;

p->se.exec_start = 0;
#ifdef CONFIG_SCHEDSTATS
p->se.wait_start = 0;
Expand All @@ -6584,8 +6581,7 @@ void normalize_rt_tasks(void)
spin_lock_irqsave(&p->pi_lock, flags);
rq = __task_rq_lock(p);

if (!is_migration_thread(p, rq))
normalize_task(rq, p);
normalize_task(rq, p);

__task_rq_unlock(rq);
spin_unlock_irqrestore(&p->pi_lock, flags);
Expand Down

0 comments on commit 178be79

Please sign in to comment.