Skip to content

Commit

Permalink
dm snapshot: delay merging a chunk until writes to it complete
Browse files Browse the repository at this point in the history
Track writes to chunks that are currently being merged and delay merging
a chunk until all writes to that chunk finish.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Mikulas Patocka authored and Alasdair G Kergon committed Dec 10, 2009
1 parent 9fe8625 commit 17aa033
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/md/dm-snap.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ static void snapshot_merge_next_chunks(struct dm_snapshot *s)
s->num_merging_chunks = 1;
up_write(&s->lock);

/* !!! FIXME: wait until writes to this chunk drain */
__check_for_conflicting_io(s, old_chunk);

dm_kcopyd_copy(s->kcopyd_client, &src, 1, &dest, 0, merge_callback, s);
return;
Expand Down Expand Up @@ -1635,7 +1635,11 @@ static int snapshot_merge_map(struct dm_target *ti, struct bio *bio,
r = DM_MAPIO_SUBMITTED;
goto out_unlock;
}

remap_exception(s, e, bio, chunk);

if (bio_rw(bio) == WRITE)
map_context->ptr = track_chunk(s, chunk);
goto out_unlock;
}

Expand Down

0 comments on commit 17aa033

Please sign in to comment.