Skip to content

Commit

Permalink
MSI: Rename pci_msi_supported() to pci_msi_check_device()
Browse files Browse the repository at this point in the history
As pointed out by Eric, the name pci_msi_supported() suggests it should
return a boolean value, however it doesn't. So update the name to be
a bit less confusing and update the doco too.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Michael Ellerman authored and Greg Kroah-Hartman committed May 3, 2007
1 parent 128bc5f commit 17bbc12
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/pci/msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -457,15 +457,15 @@ static int msix_capability_init(struct pci_dev *dev,
}

/**
* pci_msi_supported - check whether MSI may be enabled on device
* pci_msi_check_device - check whether MSI may be enabled on a device
* @dev: pointer to the pci_dev data structure of MSI device function
* @type: are we checking for MSI or MSI-X ?
*
* Look at global flags, the device itself, and its parent busses
* to return 0 if MSI are supported for the device.
* to determine if MSI/-X are supported for the device. If MSI/-X is
* supported return 0, else return an error code.
**/
static
int pci_msi_supported(struct pci_dev * dev, int type)
static int pci_msi_check_device(struct pci_dev * dev, int type)
{
struct pci_bus *bus;

Expand Down Expand Up @@ -503,7 +503,7 @@ int pci_enable_msi(struct pci_dev* dev)
{
int status;

if (pci_msi_supported(dev, PCI_CAP_ID_MSI))
if (pci_msi_check_device(dev, PCI_CAP_ID_MSI))
return -EINVAL;

WARN_ON(!!dev->msi_enabled);
Expand Down Expand Up @@ -601,7 +601,7 @@ int pci_enable_msix(struct pci_dev* dev, struct msix_entry *entries, int nvec)
int i, j;
u16 control;

if (!entries || pci_msi_supported(dev, PCI_CAP_ID_MSIX))
if (!entries || pci_msi_check_device(dev, PCI_CAP_ID_MSIX))
return -EINVAL;

pos = pci_find_capability(dev, PCI_CAP_ID_MSIX);
Expand Down

0 comments on commit 17bbc12

Please sign in to comment.