Skip to content

Commit

Permalink
goldfish: Add a FIXME note to the pipe driver
Browse files Browse the repository at this point in the history
Note a point in the pipe driver that wants future attention

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Jan 24, 2013
1 parent c89f275 commit 17c4c9d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/platform/goldfish/goldfish_pipe.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
int status, wakeBit;

/* Ensure that the corresponding page is properly mapped */
/* FIXME: this isn't safe or sufficient - use get_user_pages */
if (is_write) {
char c;
/* Ensure that the page is mapped and readable */
Expand Down

0 comments on commit 17c4c9d

Please sign in to comment.