Skip to content

Commit

Permalink
usb: gadget: u_serial: eliminate abuse of ep->driver data
Browse files Browse the repository at this point in the history
Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of u_serial ep->driver_data stores pointer to struct gs_port,
which is referenced in many places in code. Code using ep->driver_data
to mark endpoint as enabled/disabled has been removed.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Robert Baldyga authored and Felipe Balbi committed Sep 27, 2015
1 parent 6e4bfc5 commit 18411c0
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/usb/gadget/function/u_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,6 @@ static void gs_close(struct tty_struct *tty, struct file *file)
else
gs_buf_clear(&port->port_write_buf);

tty->driver_data = NULL;
port->port.tty = NULL;

port->openclose = false;
Expand Down Expand Up @@ -1224,7 +1223,6 @@ int gserial_connect(struct gserial *gser, u8 port_num)

fail_out:
usb_ep_disable(gser->in);
gser->in->driver_data = NULL;
return status;
}
EXPORT_SYMBOL_GPL(gserial_connect);
Expand Down Expand Up @@ -1264,10 +1262,7 @@ void gserial_disconnect(struct gserial *gser)

/* disable endpoints, aborting down any active I/O */
usb_ep_disable(gser->out);
gser->out->driver_data = NULL;

usb_ep_disable(gser->in);
gser->in->driver_data = NULL;

/* finally, free any unused/unusable I/O buffers */
spin_lock_irqsave(&port->port_lock, flags);
Expand Down

0 comments on commit 18411c0

Please sign in to comment.