Skip to content

Commit

Permalink
class: rename "interfaces" to "class_interfaces" in internal class st…
Browse files Browse the repository at this point in the history
…ructure

This renames the struct class "interfaces" field to be
"class_interfaces" to make things easier when struct bus_type and struct
class merge in the future.  It also makes grepping for fields easier as
well.

Based on an idea from Kay.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jul 22, 2008
1 parent 97ae69f commit 184f1f7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions drivers/base/base.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct driver_private {
* @subsys - the struct kset that defines this class. This is the main kobject
* @children - list of class_devices associated with this class
* @class_devices - list of devices associated with this class
* @interfaces - list of class_interfaces associated with this class
* @class_interfaces - list of class_interfaces associated with this class
* @class_dirs -
* @sem - semaphore to protect the children, devices, and interfaces lists.
* @class - pointer back to the struct class that this structure is associated
Expand All @@ -56,7 +56,7 @@ struct driver_private {
struct class_private {
struct kset subsys;
struct list_head class_devices;
struct list_head interfaces;
struct list_head class_interfaces;
struct kset class_dirs;
struct semaphore sem;
struct class *class;
Expand Down
4 changes: 2 additions & 2 deletions drivers/base/class.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ int class_register(struct class *cls)
if (!cp)
return -ENOMEM;
INIT_LIST_HEAD(&cp->class_devices);
INIT_LIST_HEAD(&cp->interfaces);
INIT_LIST_HEAD(&cp->class_interfaces);
kset_init(&cp->class_dirs);
init_MUTEX(&cp->sem);
error = kobject_set_name(&cp->subsys.kobj, "%s", cls->name);
Expand Down Expand Up @@ -372,7 +372,7 @@ int class_interface_register(struct class_interface *class_intf)
return -EINVAL;

down(&parent->p->sem);
list_add_tail(&class_intf->node, &parent->p->interfaces);
list_add_tail(&class_intf->node, &parent->p->class_interfaces);
if (class_intf->add_dev) {
list_for_each_entry(dev, &parent->p->class_devices, node)
class_intf->add_dev(dev, class_intf);
Expand Down
8 changes: 4 additions & 4 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,8 @@ int device_add(struct device *dev)
list_add_tail(&dev->node, &dev->class->p->class_devices);

/* notify any interfaces that the device is here */
list_for_each_entry(class_intf, &dev->class->p->interfaces,
node)
list_for_each_entry(class_intf,
&dev->class->p->class_interfaces, node)
if (class_intf->add_dev)
class_intf->add_dev(dev, class_intf);
up(&dev->class->p->sem);
Expand Down Expand Up @@ -1016,8 +1016,8 @@ void device_del(struct device *dev)

down(&dev->class->p->sem);
/* notify any interfaces that the device is now gone */
list_for_each_entry(class_intf, &dev->class->p->interfaces,
node)
list_for_each_entry(class_intf,
&dev->class->p->class_interfaces, node)
if (class_intf->remove_dev)
class_intf->remove_dev(dev, class_intf);
/* remove the device from the class list */
Expand Down

0 comments on commit 184f1f7

Please sign in to comment.