Skip to content

Commit

Permalink
firewire: core: header file cleanup
Browse files Browse the repository at this point in the history
fw_card_get, fw_card_put, fw_card_release are currently not exported for
use outside the firewire-core.  Move their definitions/ declarations
from the subsystem header file to the core header file.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed Sep 12, 2009
1 parent 928ec5f commit 18668ff
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 14 additions & 0 deletions drivers/firewire/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ int fw_core_initiate_bus_reset(struct fw_card *card, int short_reset);
int fw_compute_block_crc(u32 *block);
void fw_schedule_bm_work(struct fw_card *card, unsigned long delay);

static inline struct fw_card *fw_card_get(struct fw_card *card)
{
kref_get(&card->kref);

return card;
}

void fw_card_release(struct kref *kref);

static inline void fw_card_put(struct fw_card *card)
{
kref_put(&card->kref, fw_card_release);
}


/* -cdev */

Expand Down
14 changes: 0 additions & 14 deletions include/linux/firewire.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,6 @@ struct fw_card {
u32 topology_map[(CSR_TOPOLOGY_MAP_END - CSR_TOPOLOGY_MAP) / 4];
};

static inline struct fw_card *fw_card_get(struct fw_card *card)
{
kref_get(&card->kref);

return card;
}

void fw_card_release(struct kref *kref);

static inline void fw_card_put(struct fw_card *card)
{
kref_put(&card->kref, fw_card_release);
}

struct fw_attribute_group {
struct attribute_group *groups[2];
struct attribute_group group;
Expand Down

0 comments on commit 18668ff

Please sign in to comment.