Skip to content

Commit

Permalink
fat: fix utf8 iocharset warning message
Browse files Browse the repository at this point in the history
The fat_msg function already formats the given message and appends
a newline to it - we don't need to do this in the passed message
string as well, or will end up with a blank line printed in the
kernel log ring buffer.

Also change the loglevel from error to warning.

Signed-off-by: Mihai Moldovan <ionic@ionic.de>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
  • Loading branch information
Mihai Moldovan authored and OGAWA Hirofumi committed Aug 17, 2011
1 parent 8c320c0 commit 186b537
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/fat/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1186,9 +1186,9 @@ static int parse_options(struct super_block *sb, char *options, int is_vfat,
out:
/* UTF-8 doesn't provide FAT semantics */
if (!strcmp(opts->iocharset, "utf8")) {
fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
fat_msg(sb, KERN_WARNING, "utf8 is not a recommended IO charset"
" for FAT filesystems, filesystem will be "
"case sensitive!\n");
"case sensitive!");
}

/* If user doesn't specify allow_utime, it's initialized from dmask. */
Expand Down

0 comments on commit 186b537

Please sign in to comment.