Skip to content

Commit

Permalink
phy: twl4030-usb: remove pointless 'suspended' test in 'suspend' call…
Browse files Browse the repository at this point in the history
…back.

When the runtime_suspend callback is running, 'runtime_status'
is always RPM_SUSPENDING, so pm_runtime_suspended() will always
fail.
Similarly while the runtime_resume callback is running
'runtime_status' is RPM_RESUMING, so pm_runtime_active() will
always fail.

So remove these two pointless tests.

Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
  • Loading branch information
NeilBrown authored and Kishon Vijay Abraham I committed Jun 1, 2015
1 parent 56301df commit 186eceb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/phy/phy-twl4030-usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,6 @@ static int twl4030_usb_runtime_suspend(struct device *dev)
struct twl4030_usb *twl = dev_get_drvdata(dev);

dev_dbg(twl->dev, "%s\n", __func__);
if (pm_runtime_suspended(dev))
return 0;

__twl4030_phy_power(twl, 0);
regulator_disable(twl->usb1v5);
Expand All @@ -413,8 +411,6 @@ static int twl4030_usb_runtime_resume(struct device *dev)
int res;

dev_dbg(twl->dev, "%s\n", __func__);
if (pm_runtime_active(dev))
return 0;

res = regulator_enable(twl->usb3v1);
if (res)
Expand Down

0 comments on commit 186eceb

Please sign in to comment.