Skip to content

Commit

Permalink
lp8727_charger: Use specific definition
Browse files Browse the repository at this point in the history
Add new LP8727_ICHG_SHIFT definition and replace a magic number. Reuse
definition for the size of interrupt register buffer.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
  • Loading branch information
Kim, Milo authored and Anton Vorontsov committed Sep 21, 2012
1 parent 6029719 commit 18763a3
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/power/lp8727_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
#define LP8727_TEMP_STAT (3 << 5)
#define LP8727_TEMP_SHIFT 5

/* CHGCTRL2 register */
#define LP8727_ICHG_SHIFT 4

enum lp8727_dev_id {
LP8727_ID_NONE,
LP8727_ID_TA,
Expand Down Expand Up @@ -222,11 +225,11 @@ static void lp8727_enable_chgdet(struct lp8727_chg *pchg)

static void lp8727_delayed_func(struct work_struct *_work)
{
u8 intstat[2], idno, vbus;
u8 intstat[LP8788_NUM_INTREGS], idno, vbus;
struct lp8727_chg *pchg =
container_of(_work, struct lp8727_chg, work.work);

if (lp8727_read_bytes(pchg, LP8727_INT1, intstat, 2)) {
if (lp8727_read_bytes(pchg, LP8727_INT1, intstat, LP8788_NUM_INTREGS)) {
dev_err(pchg->dev, "can not read INT registers\n");
return;
}
Expand Down Expand Up @@ -401,7 +404,7 @@ static void lp8727_charger_changed(struct power_supply *psy)
if (pchg->chg_parm) {
eoc_level = pchg->chg_parm->eoc_level;
ichg = pchg->chg_parm->ichg;
val = (ichg << 4) | eoc_level;
val = (ichg << LP8727_ICHG_SHIFT) | eoc_level;
lp8727_write_byte(pchg, LP8727_CHGCTRL2, val);
}
}
Expand Down

0 comments on commit 18763a3

Please sign in to comment.