Skip to content

Commit

Permalink
firewire: core: make address handler length 64 bits
Browse files Browse the repository at this point in the history
The type of the length field of the fw_address_handler structure was
size_t, which restricted it to 32 bits on 32-bit architectures.

While making it u32 would match the userspace API, all calculations on
this field use 64 bits anyway, and the ability to use 4 GB or larger
address ranges is useful in the kernel.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Clemens Ladisch authored and Stefan Richter committed May 27, 2012
1 parent 26c72e2 commit 188726e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/firewire.h
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ struct fw_transaction {

struct fw_address_handler {
u64 offset;
size_t length;
u64 length;
fw_address_callback_t address_callback;
void *callback_data;
struct list_head link;
Expand Down

0 comments on commit 188726e

Please sign in to comment.