Skip to content

Commit

Permalink
[PATCH] ucc_geth: changes to ucc_geth driver as a result of qe_lib ch…
Browse files Browse the repository at this point in the history
…anges and bugfixes

changes due to qe_lib changes include:

o removed inclusion of platform header file
o removed platform_device code, replaced with of_device
o removed typedefs
o uint -> u32 conversions
o removed following defines:
  QE_SIZEOF_BD, BD_BUFFER_ARG, BD_BUFFER_CLEAR, BD_BUFFER,
  BD_STATUS_AND_LENGTH_SET, BD_STATUS_AND_LENGTH, and BD_BUFFER_SET
  because they hid sizeof/in_be32/out_be32 operations from the reader.
o removed irrelevant comments, added others to resemble removed BD_ defines
o const'd and uncasted all get_property() assignments

bugfixes, courtesy of Scott Wood, include:

- Read phy_address as a u32, not u8.
- Match on type == "network" as well as compatible == "ucc_geth", as
  device_is_compatible() will only compare up to the length of the
  test string, allowing "ucc_geth_phy" to match as well.
- fixes the MAC setting code in ucc_geth.c.  The old code was overwriting and dereferencing random stack contents.

Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Li Yang authored and Jeff Garzik committed Oct 21, 2006
1 parent 470ea7e commit 18a8e86
Show file tree
Hide file tree
Showing 5 changed files with 475 additions and 436 deletions.
2 changes: 1 addition & 1 deletion drivers/net/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2288,7 +2288,7 @@ config UGETH_TX_ON_DEMOND

config UGETH_HAS_GIGA
bool
depends on UCC_GETH && MPC836x
depends on UCC_GETH && PPC_MPC836x

config MV643XX_ETH
tristate "MV-643XX Ethernet support"
Expand Down
Loading

0 comments on commit 18a8e86

Please sign in to comment.