Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 127004
b: refs/heads/master
c: a2ba8b1
h: refs/heads/master
v: v3
  • Loading branch information
Michael Hennerich authored and Bryan Wu committed Oct 28, 2008
1 parent 42b3606 commit 18b2879
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 19 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3529e0414b600faa1b6d822569b3343131235813
refs/heads/master: a2ba8b19989e038bdf1a9fcc25e860d5077d2474
1 change: 1 addition & 0 deletions trunk/arch/blackfin/include/asm/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ struct dma_channel {
struct dma_register *regs;
struct dmasg *sg; /* large mode descriptor */
unsigned int ctrl_num; /* controller number */
unsigned int irq;
dma_interrupt_t irq_callback;
void *data;
unsigned int dma_enable_flag;
Expand Down
24 changes: 6 additions & 18 deletions trunk/arch/blackfin/kernel/bfin_dma_5xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,19 +139,16 @@ EXPORT_SYMBOL(request_dma);

int set_dma_callback(unsigned int channel, dma_interrupt_t callback, void *data)
{
int ret_irq = 0;

BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE
&& channel < MAX_BLACKFIN_DMA_CHANNEL));

if (callback != NULL) {
int ret_val;
ret_irq = channel2irq(channel);

dma_ch[channel].irq = channel2irq(channel);
dma_ch[channel].data = data;

ret_val =
request_irq(ret_irq, (void *)callback, IRQF_DISABLED,
request_irq(dma_ch[channel].irq, callback, IRQF_DISABLED,
dma_ch[channel].device_id, data);
if (ret_val) {
printk(KERN_NOTICE
Expand All @@ -166,7 +163,6 @@ EXPORT_SYMBOL(set_dma_callback);

void free_dma(unsigned int channel)
{
int ret_irq;

pr_debug("freedma() : BEGIN \n");
BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE
Expand All @@ -176,10 +172,8 @@ void free_dma(unsigned int channel)
disable_dma(channel);
clear_dma_buffer(channel);

if (dma_ch[channel].irq_callback != NULL) {
ret_irq = channel2irq(channel);
free_irq(ret_irq, dma_ch[channel].data);
}
if (dma_ch[channel].irq_callback != NULL)
free_irq(dma_ch[channel].irq, dma_ch[channel].data);

/* Clear the DMA Variable in the Channel */
mutex_lock(&(dma_ch[channel].dmalock));
Expand All @@ -192,27 +186,21 @@ EXPORT_SYMBOL(free_dma);

void dma_enable_irq(unsigned int channel)
{
int ret_irq;

pr_debug("dma_enable_irq() : BEGIN \n");
BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE
&& channel < MAX_BLACKFIN_DMA_CHANNEL));

ret_irq = channel2irq(channel);
enable_irq(ret_irq);
enable_irq(dma_ch[channel].irq);
}
EXPORT_SYMBOL(dma_enable_irq);

void dma_disable_irq(unsigned int channel)
{
int ret_irq;

pr_debug("dma_disable_irq() : BEGIN \n");
BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE
&& channel < MAX_BLACKFIN_DMA_CHANNEL));

ret_irq = channel2irq(channel);
disable_irq(ret_irq);
disable_irq(dma_ch[channel].irq);
}
EXPORT_SYMBOL(dma_disable_irq);

Expand Down

0 comments on commit 18b2879

Please sign in to comment.