Skip to content

Commit

Permalink
ftrace: don't use raw_local_irq_save/restore
Browse files Browse the repository at this point in the history
Using raw_local_irq_save/restore confuses lockdep.
It's fine to use the normal ones.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Steven Rostedt authored and Thomas Gleixner committed May 23, 2008
1 parent 0764d23 commit 18cef37
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ function_trace_call(unsigned long ip, unsigned long parent_ip)
if (unlikely(!tracer_enabled))
return;

raw_local_irq_save(flags);
local_irq_save(flags);
cpu = raw_smp_processor_id();
data = tr->data[cpu];
disabled = atomic_inc_return(&data->disabled);
Expand All @@ -278,7 +278,7 @@ function_trace_call(unsigned long ip, unsigned long parent_ip)
ftrace(tr, data, ip, parent_ip, flags);

atomic_dec(&data->disabled);
raw_local_irq_restore(flags);
local_irq_restore(flags);
}

static struct ftrace_ops trace_ops __read_mostly =
Expand Down
4 changes: 2 additions & 2 deletions kernel/trace/trace_sched_switch.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ctx_switch_func(struct task_struct *prev, struct task_struct *next)
if (!tracer_enabled)
return;

raw_local_irq_save(flags);
local_irq_save(flags);
cpu = raw_smp_processor_id();
data = tr->data[cpu];
disabled = atomic_inc_return(&data->disabled);
Expand All @@ -38,7 +38,7 @@ ctx_switch_func(struct task_struct *prev, struct task_struct *next)
tracing_sched_switch_trace(tr, data, prev, next, flags);

atomic_dec(&data->disabled);
raw_local_irq_restore(flags);
local_irq_restore(flags);
}

void ftrace_ctx_switch(struct task_struct *prev, struct task_struct *next)
Expand Down

0 comments on commit 18cef37

Please sign in to comment.