Skip to content

Commit

Permalink
signals: check_kill_permission: remove tasklist_lock
Browse files Browse the repository at this point in the history
Now that task_session() can't return a false NULL, check_kill_permission()
doesn't need tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Apr 30, 2008
1 parent 2e2ba22 commit 1931910
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -551,9 +551,7 @@ static int check_kill_permission(int sig, struct siginfo *info,
!capable(CAP_KILL)) {
switch (sig) {
case SIGCONT:
read_lock(&tasklist_lock);
sid = task_session(t);
read_unlock(&tasklist_lock);
/*
* We don't return the error if sid == NULL. The
* task was unhashed, the caller must notice this.
Expand Down

0 comments on commit 1931910

Please sign in to comment.