Skip to content

Commit

Permalink
ocfs2: Update atime in splice read if necessary.
Browse files Browse the repository at this point in the history
We should call ocfs2_inode_lock_atime instead of ocfs2_inode_lock
in ocfs2_file_splice_read like we do in ocfs2_file_aio_read so
that we can update atime in splice read if necessary.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
  • Loading branch information
Tao Ma authored and Joel Becker committed Jun 22, 2009
1 parent 1c520df commit 1962f39
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/ocfs2/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,7 @@ static ssize_t ocfs2_file_splice_read(struct file *in,
size_t len,
unsigned int flags)
{
int ret = 0;
int ret = 0, lock_level = 0;
struct inode *inode = in->f_path.dentry->d_inode;

mlog_entry("(0x%p, 0x%p, %u, '%.*s')\n", in, pipe,
Expand All @@ -2037,12 +2037,12 @@ static ssize_t ocfs2_file_splice_read(struct file *in,
/*
* See the comment in ocfs2_file_aio_read()
*/
ret = ocfs2_inode_lock(inode, NULL, 0);
ret = ocfs2_inode_lock_atime(inode, in->f_vfsmnt, &lock_level);
if (ret < 0) {
mlog_errno(ret);
goto bail;
}
ocfs2_inode_unlock(inode, 0);
ocfs2_inode_unlock(inode, lock_level);

ret = generic_file_splice_read(in, ppos, pipe, len, flags);

Expand Down

0 comments on commit 1962f39

Please sign in to comment.