Skip to content

Commit

Permalink
lockdep: Print out additional debugging advice when we hit lockdep BUGs
Browse files Browse the repository at this point in the history
We occasionally get reports of these BUGs being hit, and the
stack trace doesn't necessarily always tell us what we need to
know about why we are hitting those limits.

If users start attaching /proc/lock_stats to reports we may have
more of a clue what's going on.

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20130423163403.GA12839@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Dave Jones authored and Ingo Molnar committed Apr 26, 2013
1 parent cc189d2 commit 199e371
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions kernel/lockdep.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ static int save_trace(struct stack_trace *trace)

printk("BUG: MAX_STACK_TRACE_ENTRIES too low!\n");
printk("turning off the locking correctness validator.\n");
printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();

return 0;
Expand Down Expand Up @@ -765,6 +766,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)

printk("BUG: MAX_LOCKDEP_KEYS too low!\n");
printk("turning off the locking correctness validator.\n");
printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return NULL;
}
Expand Down Expand Up @@ -836,6 +838,7 @@ static struct lock_list *alloc_list_entry(void)

printk("BUG: MAX_LOCKDEP_ENTRIES too low!\n");
printk("turning off the locking correctness validator.\n");
printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return NULL;
}
Expand Down Expand Up @@ -2050,6 +2053,7 @@ static inline int lookup_chain_cache(struct task_struct *curr,

printk("BUG: MAX_LOCKDEP_CHAINS too low!\n");
printk("turning off the locking correctness validator.\n");
printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return 0;
}
Expand Down Expand Up @@ -3191,6 +3195,7 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
printk("BUG: MAX_LOCK_DEPTH too low, depth: %i max: %lu!\n",
curr->lockdep_depth, MAX_LOCK_DEPTH);
printk("turning off the locking correctness validator.\n");
printk("Attach output of /proc/lock_stat to bug report\n");

lockdep_print_held_locks(current);
debug_show_all_locks();
Expand Down

0 comments on commit 199e371

Please sign in to comment.