Skip to content

Commit

Permalink
staging: comedi: dt2815: use comedi_request_region()
Browse files Browse the repository at this point in the history
Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Apr 11, 2013
1 parent c5c18cd commit 19b3da3
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/staging/comedi/drivers/dt2815.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,11 @@ static int dt2815_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct comedi_subdevice *s;
int i;
const struct comedi_lrange *current_range_type, *voltage_range_type;
unsigned long iobase;
int ret;

iobase = it->options[0];
printk(KERN_INFO "comedi%d: dt2815: 0x%04lx ", dev->minor, iobase);
if (!request_region(iobase, DT2815_SIZE, "dt2815")) {
printk(KERN_WARNING "I/O port conflict\n");
return -EIO;
}

dev->iobase = iobase;
ret = comedi_request_region(dev, it->options[0], DT2815_SIZE);
if (ret)
return ret;

ret = comedi_alloc_subdevices(dev, 1);
if (ret)
Expand Down

0 comments on commit 19b3da3

Please sign in to comment.