Skip to content

Commit

Permalink
vlan: adds drops accounting
Browse files Browse the repository at this point in the history
Its hard to tell if vlans are dropping frames, since
every frame given to vlan_???_start_xmit() functions
is accounted as fully transmitted by lower device.

We can test dev_queue_xmit() return values to
properly account for dropped frames.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Sep 4, 2009
1 parent 2c11455 commit 1a123a3
Showing 1 changed file with 22 additions and 7 deletions.
29 changes: 22 additions & 7 deletions net/8021q/vlan_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
int i = skb_get_queue_mapping(skb);
struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
struct vlan_ethhdr *veth = (struct vlan_ethhdr *)(skb->data);
unsigned int len;
int ret;

/* Handle non-VLAN frames if they are sent to us, for example by DHCP.
*
Expand All @@ -319,11 +321,17 @@ static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
vlan_dev_info(dev)->cnt_inc_headroom_on_tx++;
}

txq->tx_packets++;
txq->tx_bytes += skb->len;

skb->dev = vlan_dev_info(dev)->real_dev;
dev_queue_xmit(skb);
len = skb->len;
ret = dev_queue_xmit(skb);

if (likely(ret == NET_XMIT_SUCCESS)) {
txq->tx_packets++;
txq->tx_bytes += len;
} else
txq->tx_dropped++;

return NETDEV_TX_OK;
}

Expand All @@ -333,16 +341,23 @@ static netdev_tx_t vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
int i = skb_get_queue_mapping(skb);
struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
u16 vlan_tci;
unsigned int len;
int ret;

vlan_tci = vlan_dev_info(dev)->vlan_id;
vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
skb = __vlan_hwaccel_put_tag(skb, vlan_tci);

txq->tx_packets++;
txq->tx_bytes += skb->len;

skb->dev = vlan_dev_info(dev)->real_dev;
dev_queue_xmit(skb);
len = skb->len;
ret = dev_queue_xmit(skb);

if (likely(ret == NET_XMIT_SUCCESS)) {
txq->tx_packets++;
txq->tx_bytes += len;
} else
txq->tx_dropped++;

return NETDEV_TX_OK;
}

Expand Down

0 comments on commit 1a123a3

Please sign in to comment.