Skip to content

Commit

Permalink
phy devices: use same arg types
Browse files Browse the repository at this point in the history
sparse complains about differing types from prototype to
definition, so change the u32 to phy_interface_t:

drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at include/linux/phy.h:362) - incompatible argument 5 (different signedness)
drivers/net/phy/phy_device.c:190:19: error: symbol 'phy_attach' redeclared with different type (originally declared at include/linux/phy.h:360) - incompatible argument 4 (different signedness)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Randy Dunlap authored and Jeff Garzik committed Feb 9, 2007
1 parent a3cc2de commit 1a16893
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/phy/phy_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ void phy_prepare_link(struct phy_device *phydev,
*/
struct phy_device * phy_connect(struct net_device *dev, const char *phy_id,
void (*handler)(struct net_device *), u32 flags,
u32 interface)
phy_interface_t interface)
{
struct phy_device *phydev;

Expand Down Expand Up @@ -188,7 +188,7 @@ static int phy_compare_id(struct device *dev, void *data)
}

struct phy_device *phy_attach(struct net_device *dev,
const char *phy_id, u32 flags, u32 interface)
const char *phy_id, u32 flags, phy_interface_t interface)
{
struct bus_type *bus = &mdio_bus_type;
struct phy_device *phydev;
Expand Down

0 comments on commit 1a16893

Please sign in to comment.