Skip to content

Commit

Permalink
nfsd4: allow an EXCHANGE_ID to kill a 4.0 client
Browse files Browse the repository at this point in the history
Following rfc 5661 section 2.4.1, we can permit a 4.1 client to remove
an established 4.0 client's state.

(But we don't allow updates.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Jun 1, 2012
1 parent ea236d0 commit 1a30811
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -1553,8 +1553,10 @@ nfsd4_exchange_id(struct svc_rqst *rqstp,
conf = find_confirmed_client_by_str(dname, strhashval);
if (conf) {
if (!clp_used_exchangeid(conf)) {
status = nfserr_clid_inuse; /* XXX: ? */
goto out;
if (exid->flags & EXCHGID4_FLAG_UPD_CONFIRMED_REC_A) {
status = nfserr_inval; /* buggy client */
goto out;
}
}
if (!same_creds(&conf->cl_cred, &rqstp->rq_cred)) {
/* 18.35.4 case 9 */
Expand All @@ -1574,6 +1576,10 @@ nfsd4_exchange_id(struct svc_rqst *rqstp,
expire_client(conf);
goto out_new;
}
if (!clp_used_exchangeid(conf)) {
status = nfserr_inval;
goto out;
}
/*
* Set bit when the owner id and verifier map to an already
* confirmed client id (18.35.3).
Expand Down

0 comments on commit 1a30811

Please sign in to comment.