Skip to content

Commit

Permalink
hwmon: (emc2103) Fix return value
Browse files Browse the repository at this point in the history
kstrtol() returns appropriate error values. Use those instead of
hardcoding. Silences several sparse messages of following type:
"why not propagate 'result' from kstrtol() instead of (-22)?"

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Sachin Kamat authored and Guenter Roeck committed Sep 11, 2013
1 parent a22a0fd commit 1a3abbd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/hwmon/emc2103.c
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *da,

int result = kstrtol(buf, 10, &val);
if (result < 0)
return -EINVAL;
return result;

val = DIV_ROUND_CLOSEST(val, 1000);
if ((val < -63) || (val > 127))
Expand All @@ -272,7 +272,7 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *da,

int result = kstrtol(buf, 10, &val);
if (result < 0)
return -EINVAL;
return result;

val = DIV_ROUND_CLOSEST(val, 1000);
if ((val < -63) || (val > 127))
Expand Down Expand Up @@ -320,7 +320,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *da,

int status = kstrtol(buf, 10, &new_div);
if (status < 0)
return -EINVAL;
return status;

if (new_div == old_div) /* No change */
return count;
Expand Down Expand Up @@ -394,7 +394,7 @@ static ssize_t set_fan_target(struct device *dev, struct device_attribute *da,

int result = kstrtol(buf, 10, &rpm_target);
if (result < 0)
return -EINVAL;
return result;

/* Datasheet states 16384 as maximum RPM target (table 3.2) */
if ((rpm_target < 0) || (rpm_target > 16384))
Expand Down Expand Up @@ -440,7 +440,7 @@ static ssize_t set_pwm_enable(struct device *dev, struct device_attribute *da,

int result = kstrtol(buf, 10, &new_value);
if (result < 0)
return -EINVAL;
return result;

mutex_lock(&data->update_lock);
switch (new_value) {
Expand Down

0 comments on commit 1a3abbd

Please sign in to comment.