Skip to content

Commit

Permalink
perf_counter: Fix userspace build
Browse files Browse the repository at this point in the history
recent userspace (F11) seems to already include the
linux/unistd.h bits which means we cannot include the version
in the kernel sources due to the header guards being the same.

Ensure we include the kernel version first.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
LKML-Reference: <20090523163012.739756497@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed May 23, 2009
1 parent 682076a commit 1a482f3
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 22 deletions.
3 changes: 1 addition & 2 deletions Documentation/perf_counter/builtin-record.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@


#include "perf.h"
#include "util/util.h"

#include <sys/types.h>
Expand Down Expand Up @@ -30,9 +31,7 @@
#include <linux/unistd.h>
#include <linux/types.h>

#include "../../include/linux/perf_counter.h"

#include "perf.h"

#define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1)
#define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask))
Expand Down
5 changes: 1 addition & 4 deletions Documentation/perf_counter/builtin-stat.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* Released under the GPL v2. (and only v2, not any later version)
*/

#include "perf.h"
#include "util/util.h"

#include <getopt.h>
Expand All @@ -83,10 +84,6 @@
#include <linux/unistd.h>
#include <linux/types.h>

#include "../../include/linux/perf_counter.h"

#include "perf.h"

#define EVENT_MASK_KERNEL 1
#define EVENT_MASK_USER 2

Expand Down
5 changes: 1 addition & 4 deletions Documentation/perf_counter/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
* Released under the GPL v2. (and only v2, not any later version)
*/

#include "perf.h"
#include "util/util.h"

#include <getopt.h>
Expand All @@ -64,10 +65,6 @@
#include <linux/unistd.h>
#include <linux/types.h>

#include "../../include/linux/perf_counter.h"

#include "perf.h"

static int system_wide = 0;

static int nr_counters = 0;
Expand Down
31 changes: 19 additions & 12 deletions Documentation/perf_counter/perf.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,25 @@
#ifndef _PERF_PERF_H
#define _PERF_PERF_H

#if defined(__x86_64__) || defined(__i386__)
#include "../../arch/x86/include/asm/unistd.h"
#define rmb() asm volatile("lfence" ::: "memory")
#define cpu_relax() asm volatile("rep; nop" ::: "memory");
#endif

#ifdef __powerpc__
#include "../../arch/powerpc/include/asm/unistd.h"
#define rmb() asm volatile ("sync" ::: "memory")
#define cpu_relax() asm volatile ("" ::: "memory");
#endif

#include <time.h>
#include <unistd.h>
#include <sys/types.h>
#include <sys/syscall.h>

#include "../../include/linux/perf_counter.h"

/*
* prctl(PR_TASK_PERF_COUNTERS_DISABLE) will (cheaply) disable all
* counters in the current task.
Expand All @@ -26,18 +45,6 @@ static inline unsigned long long rdclock(void)
#define __user
#define asmlinkage

#if defined(__x86_64__) || defined(__i386__)
#include "../../arch/x86/include/asm/unistd.h"
#define rmb() asm volatile("lfence" ::: "memory")
#define cpu_relax() asm volatile("rep; nop" ::: "memory");
#endif

#ifdef __powerpc__
#include "../../arch/powerpc/include/asm/unistd.h"
#define rmb() asm volatile ("sync" ::: "memory")
#define cpu_relax() asm volatile ("" ::: "memory");
#endif

#define unlikely(x) __builtin_expect(!!(x), 0)
#define min(x, y) ({ \
typeof(x) _min1 = (x); \
Expand Down

0 comments on commit 1a482f3

Please sign in to comment.