Skip to content

Commit

Permalink
Re: [PATCH] Fix the kernel panic of audit_filter_task when key field …
Browse files Browse the repository at this point in the history
…is set

Sorry, I miss a blank between if and "(".
And I add "unlikely" to check "ctx" in audit_match_perm() and audit_match_filetype().
This is a new patch for it.

Signed-off-by: Zhang Xiliang <zhangxiliang@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
zhangxiliang authored and Al Viro committed Aug 4, 2008
1 parent 2b12a4c commit 1a61c88
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions kernel/auditsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ static inline int open_arg(int flags, int mask)

static int audit_match_perm(struct audit_context *ctx, int mask)
{
if (unlikely(!ctx))
return 0;

unsigned n = ctx->major;
switch (audit_classify_syscall(ctx->arch, n)) {
case 0: /* native */
Expand Down Expand Up @@ -284,6 +287,10 @@ static int audit_match_filetype(struct audit_context *ctx, int which)
{
unsigned index = which & ~S_IFMT;
mode_t mode = which & S_IFMT;

if (unlikely(!ctx))
return 0;

if (index >= ctx->name_count)
return 0;
if (ctx->names[index].ino == -1)
Expand Down

0 comments on commit 1a61c88

Please sign in to comment.