Skip to content

Commit

Permalink
myri10ge: handle failures in suspend and resume
Browse files Browse the repository at this point in the history
On suspend, handle pci_set_power_state errors, and on resume
handle failures in pci_resume_state().

Signed-off-by: Brice Goglin <brice@myri.com>
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Brice Goglin authored and Jeff Garzik committed Dec 26, 2006
1 parent 83f6e15 commit 1a63e84
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/net/myri10ge/myri10ge.c
Original file line number Diff line number Diff line change
Expand Up @@ -2540,8 +2540,8 @@ static int myri10ge_suspend(struct pci_dev *pdev, pm_message_t state)
myri10ge_dummy_rdma(mgp, 0);
pci_save_state(pdev);
pci_disable_device(pdev);
pci_set_power_state(pdev, pci_choose_state(pdev, state));
return 0;

return pci_set_power_state(pdev, pci_choose_state(pdev, state));
}

static int myri10ge_resume(struct pci_dev *pdev)
Expand All @@ -2564,12 +2564,14 @@ static int myri10ge_resume(struct pci_dev *pdev)
return -EIO;
}

pci_restore_state(pdev);
status = pci_restore_state(pdev);
if (status)
return status;

status = pci_enable_device(pdev);
if (status < 0) {
if (status) {
dev_err(&pdev->dev, "failed to enable device\n");
return -EIO;
return status;
}

pci_set_master(pdev);
Expand Down

0 comments on commit 1a63e84

Please sign in to comment.