Skip to content

Commit

Permalink
Staging: comedi: fix printk issue in ni_daq_dio24.c
Browse files Browse the repository at this point in the history
This is a patch to the ni_daq_dio24.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Converted printks to pr_<levels> and dev_version.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Ravishankar karkala Mallikarjunayya authored and Greg Kroah-Hartman committed Nov 27, 2011
1 parent ef7908e commit 1aa301e
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions drivers/staging/comedi/drivers/ni_daq_dio24.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,19 @@ static int dio24_attach(struct comedi_device *dev, struct comedi_devconfig *it)
#endif
break;
default:
printk("bug! couldn't determine board type\n");
pr_err("bug! couldn't determine board type\n");
return -EINVAL;
break;
}
printk("comedi%d: ni_daq_dio24: %s, io 0x%lx", dev->minor,
thisboard->name, iobase);
pr_debug("comedi%d: ni_daq_dio24: %s, io 0x%lx", dev->minor,
thisboard->name, iobase);
#ifdef incomplete
if (irq)
printk(", irq %u", irq);
pr_debug("irq %u\n", irq);
#endif

printk("\n");

if (iobase == 0) {
printk("io base address is zero!\n");
pr_err("io base address is zero!\n");
return -EINVAL;
}

Expand All @@ -172,7 +170,7 @@ static int dio24_attach(struct comedi_device *dev, struct comedi_devconfig *it)

static int dio24_detach(struct comedi_device *dev)
{
printk("comedi%d: ni_daq_dio24: remove\n", dev->minor);
dev_info(dev->hw_dev, "comedi%d: ni_daq_dio24: remove\n", dev->minor);

if (dev->subdevices)
subdev_8255_cleanup(dev, dev->subdevices + 0);
Expand Down

0 comments on commit 1aa301e

Please sign in to comment.