Skip to content

Commit

Permalink
net/davinci_emac: fix failing PHY connect attempts
Browse files Browse the repository at this point in the history
PHY connect attempts fail if no PHY id is specified in the emac platform
data and another mdio bus has been registered before 'davinci_mdio' bus. In
this case when configuring the interface, there will be an attempt to
connect to already attached PHY on the previously registered mdio bus:

net eth1: PHY already attached
net eth1: could not connect to phy smsc911x-0:01
IP-Config: Failed to open eth1
IP-Config: Device `eth1' not found

Fix this by modifying match_first_device() to match first PHY device
on 'davinci_mdio' bus.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Anatolij Gustschin authored and David S. Miller committed Apr 24, 2012
1 parent c2f1244 commit 1ab8be4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/ti/davinci_emac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1511,7 +1511,7 @@ static int emac_devioctl(struct net_device *ndev, struct ifreq *ifrq, int cmd)

static int match_first_device(struct device *dev, void *data)
{
return 1;
return !strncmp(dev_name(dev), "davinci_mdio", 12);
}

/**
Expand Down

0 comments on commit 1ab8be4

Please sign in to comment.