Skip to content

Commit

Permalink
ath9k: avoid usage of ath9k_hw_setpower() on hw.c
Browse files Browse the repository at this point in the history
ath9k_hw_setpower() is a core driver helper with locking
protection. Locking protection should be left to the driver
core, not the hw code. Hardware code no longer contends for
locking when it needs to wake up the chip or put it to sleep.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Luis R. Rodriguez authored and John W. Linville committed Oct 7, 2009
1 parent a91d75a commit 1adc93c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/wireless/ath/ath9k/hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ int ath9k_hw_init(struct ath_hw *ah)
return -EIO;
}

if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE)) {
if (!ath9k_hw_setpower_nolock(ah, ATH9K_PM_AWAKE)) {
DPRINTF(ah, ATH_DBG_FATAL, "Couldn't wakeup chip\n");
return -EIO;
}
Expand Down Expand Up @@ -1234,7 +1234,7 @@ void ath9k_hw_detach(struct ath_hw *ah)
ath9k_hw_ani_disable(ah);

ath9k_hw_rf_free(ah);
ath9k_hw_setpower(ah, ATH9K_PM_FULL_SLEEP);
ath9k_hw_setpower_nolock(ah, ATH9K_PM_FULL_SLEEP);
kfree(ah);
ah = NULL;
}
Expand Down Expand Up @@ -1800,7 +1800,7 @@ static bool ath9k_hw_chip_reset(struct ath_hw *ah,
} else if (!ath9k_hw_set_reset_reg(ah, ATH9K_RESET_WARM))
return false;

if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE))
if (!ath9k_hw_setpower_nolock(ah, ATH9K_PM_AWAKE))
return false;

ah->chip_fullsleep = false;
Expand Down Expand Up @@ -2355,7 +2355,7 @@ int ath9k_hw_reset(struct ath_hw *ah, struct ath9k_channel *chan,
ah->txchainmask = sc->tx_chainmask;
ah->rxchainmask = sc->rx_chainmask;

if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE))
if (!ath9k_hw_setpower_nolock(ah, ATH9K_PM_AWAKE))
return -EIO;

if (curchan && !ah->chip_fullsleep)
Expand Down Expand Up @@ -3998,7 +3998,7 @@ bool ath9k_hw_phy_disable(struct ath_hw *ah)

bool ath9k_hw_disable(struct ath_hw *ah)
{
if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE))
if (!ath9k_hw_setpower_nolock(ah, ATH9K_PM_AWAKE))
return false;

return ath9k_hw_set_reset_reg(ah, ATH9K_RESET_COLD);
Expand Down

0 comments on commit 1adc93c

Please sign in to comment.