Skip to content

Commit

Permalink
[NETFILTER]: fix ebtable targets return
Browse files Browse the repository at this point in the history
The function ebt_do_table doesn't take NF_DROP as a verdict from the targets.

Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joonwoo Park authored and David S. Miller committed Feb 24, 2008
1 parent 34cc7ba commit 1b04ab4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion net/bridge/netfilter/ebt_dnat.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ static int ebt_target_dnat(struct sk_buff *skb, unsigned int hooknr,
const struct ebt_nat_info *info = data;

if (!skb_make_writable(skb, 0))
return NF_DROP;
return EBT_DROP;

memcpy(eth_hdr(skb)->h_dest, info->mac, ETH_ALEN);
return info->target;
Expand Down
2 changes: 1 addition & 1 deletion net/bridge/netfilter/ebt_redirect.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ static int ebt_target_redirect(struct sk_buff *skb, unsigned int hooknr,
const struct ebt_redirect_info *info = data;

if (!skb_make_writable(skb, 0))
return NF_DROP;
return EBT_DROP;

if (hooknr != NF_BR_BROUTING)
memcpy(eth_hdr(skb)->h_dest,
Expand Down
2 changes: 1 addition & 1 deletion net/bridge/netfilter/ebt_snat.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ static int ebt_target_snat(struct sk_buff *skb, unsigned int hooknr,
const struct ebt_nat_info *info = data;

if (!skb_make_writable(skb, 0))
return NF_DROP;
return EBT_DROP;

memcpy(eth_hdr(skb)->h_source, info->mac, ETH_ALEN);
if (!(info->target & NAT_ARP_BIT) &&
Expand Down

0 comments on commit 1b04ab4

Please sign in to comment.