Skip to content

Commit

Permalink
USB: input: wacom_sys.c: fix up dev_err() usage
Browse files Browse the repository at this point in the history
We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Ping Cheng <pingc@wacom.com>
CC: Chris Bagwell <chris@cnpbagwell.com>
CC: Eduard Hasenleithner <eduard@hasenleithner.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed May 2, 2012
1 parent 3415b57 commit 1b5ca92
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/input/tablet/wacom_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static void wacom_sys_irq(struct urb *urb)
usb_mark_last_busy(wacom->usbdev);
retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval)
dev_err(&wacom->intf->dev,
dev_err(&wacom->wacom_wac.input->dev,
"%s - usb_submit_urb failed with result %d\n",
__func__, retval);
}
Expand Down Expand Up @@ -818,7 +818,7 @@ static int wacom_initialize_leds(struct wacom *wacom)
}

if (error) {
dev_err(&wacom->intf->dev,
dev_err(&wacom->wacom_wac.input->dev,
"cannot create sysfs group err: %d\n", error);
return error;
}
Expand Down

0 comments on commit 1b5ca92

Please sign in to comment.