Skip to content

Commit

Permalink
staging:iio: Add core attribute handling for name of device.
Browse files Browse the repository at this point in the history
Saves on a fair bit of code replication.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jonathan Cameron authored and Greg Kroah-Hartman committed May 19, 2011
1 parent 51c060a commit 1b73288
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/iio/iio.h
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ struct iio_dev {
int num_channels;
struct list_head channel_attr_list;

char *name; /*device name - IMPLEMENT */
const char *name;
int (*read_raw)(struct iio_dev *indio_dev,
struct iio_chan_spec const *chan,
int *val,
Expand Down
23 changes: 22 additions & 1 deletion drivers/staging/iio/industrialio-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,16 @@ static void iio_device_remove_and_free_read_attr(struct iio_dev *dev_info,
kfree(p);
}

static ssize_t iio_show_dev_name(struct device *dev,
struct device_attribute *attr,
char *buf)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", indio_dev->name);
}

static DEVICE_ATTR(name, S_IRUGO, iio_show_dev_name, NULL);

static int iio_device_register_sysfs(struct iio_dev *dev_info)
{
int i, ret = 0;
Expand Down Expand Up @@ -715,8 +725,15 @@ static int iio_device_register_sysfs(struct iio_dev *dev_info)
if (ret < 0)
goto error_clear_attrs;
}

if (dev_info->name) {
ret = sysfs_add_file_to_group(&dev_info->dev.kobj,
&dev_attr_name.attr,
NULL);
if (ret)
goto error_clear_attrs;
}
return 0;

error_clear_attrs:
list_for_each_entry_safe(p, n,
&dev_info->channel_attr_list, l) {
Expand All @@ -734,6 +751,10 @@ static void iio_device_unregister_sysfs(struct iio_dev *dev_info)
{

struct iio_dev_attr *p, *n;
if (dev_info->name)
sysfs_remove_file_from_group(&dev_info->dev.kobj,
&dev_attr_name.attr,
NULL);
list_for_each_entry_safe(p, n, &dev_info->channel_attr_list, l) {
list_del(&p->l);
iio_device_remove_and_free_read_attr(dev_info, p);
Expand Down

0 comments on commit 1b73288

Please sign in to comment.