Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 346434
b: refs/heads/master
c: 0d7ecb8
h: refs/heads/master
v: v3
  • Loading branch information
Devendra Naga authored and Linus Torvalds committed Dec 18, 2012
1 parent de8beef commit 1b80298
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 968d21c2cf01bde4b0e3ff0b0f821b51b9da8ffd
refs/heads/master: 0d7ecb8389a34f650f0d4ab23a56c94595a75ccf
15 changes: 5 additions & 10 deletions trunk/drivers/rtc/rtc-vt8500.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,8 @@ static int __devinit vt8500_rtc_probe(struct platform_device *pdev)
struct vt8500_rtc *vt8500_rtc;
int ret;

vt8500_rtc = kzalloc(sizeof(struct vt8500_rtc), GFP_KERNEL);
vt8500_rtc = devm_kzalloc(&pdev->dev,
sizeof(struct vt8500_rtc), GFP_KERNEL);
if (!vt8500_rtc)
return -ENOMEM;

Expand All @@ -220,24 +221,21 @@ static int __devinit vt8500_rtc_probe(struct platform_device *pdev)
vt8500_rtc->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!vt8500_rtc->res) {
dev_err(&pdev->dev, "No I/O memory resource defined\n");
ret = -ENXIO;
goto err_free;
return -ENXIO;
}

vt8500_rtc->irq_alarm = platform_get_irq(pdev, 0);
if (vt8500_rtc->irq_alarm < 0) {
dev_err(&pdev->dev, "No alarm IRQ resource defined\n");
ret = -ENXIO;
goto err_free;
return -ENXIO;
}

vt8500_rtc->res = request_mem_region(vt8500_rtc->res->start,
resource_size(vt8500_rtc->res),
"vt8500-rtc");
if (vt8500_rtc->res == NULL) {
dev_err(&pdev->dev, "failed to request I/O memory\n");
ret = -EBUSY;
goto err_free;
return -EBUSY;
}

vt8500_rtc->regbase = ioremap(vt8500_rtc->res->start,
Expand Down Expand Up @@ -278,8 +276,6 @@ static int __devinit vt8500_rtc_probe(struct platform_device *pdev)
err_release:
release_mem_region(vt8500_rtc->res->start,
resource_size(vt8500_rtc->res));
err_free:
kfree(vt8500_rtc);
return ret;
}

Expand All @@ -297,7 +293,6 @@ static int __devexit vt8500_rtc_remove(struct platform_device *pdev)
release_mem_region(vt8500_rtc->res->start,
resource_size(vt8500_rtc->res));

kfree(vt8500_rtc);
platform_set_drvdata(pdev, NULL);

return 0;
Expand Down

0 comments on commit 1b80298

Please sign in to comment.