Skip to content

Commit

Permalink
Staging: poch: Fine grained locking
Browse files Browse the repository at this point in the history
Lock only the portion of code that does register access.

Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Vijay Kumar authored and Greg Kroah-Hartman committed Jan 6, 2009
1 parent bf43701 commit 1b8ee91
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/staging/poch/poch.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,27 +485,30 @@ static void channel_dma_init(struct channel_info *channel)
/* The DMA address page register is shared between the RX and
* TX channels, so acquire lock.
*/
spin_lock(channel->iomem_lock);
for (i = 0; i < channel->group_count; i++) {
page = i / 32;
group_in_page = i % 32;

group_reg = group_regs_base + (group_in_page * 4);

spin_lock(channel->iomem_lock);
iowrite32(page, fpga + FPGA_DMA_ADR_PAGE_REG);
iowrite32(channel->groups[i].dma_addr, fpga + group_reg);
spin_unlock(channel->iomem_lock);
}

for (i = 0; i < channel->group_count; i++) {
page = i / 32;
group_in_page = i % 32;

group_reg = group_regs_base + (group_in_page * 4);

spin_lock(channel->iomem_lock);
iowrite32(page, fpga + FPGA_DMA_ADR_PAGE_REG);
printk(KERN_INFO PFX "%ld: read dma_addr: 0x%x\n", i,
ioread32(fpga + group_reg));
spin_unlock(channel->iomem_lock);
}
spin_unlock(channel->iomem_lock);

}

Expand Down

0 comments on commit 1b8ee91

Please sign in to comment.