Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 217339
b: refs/heads/master
c: a08c80e
h: refs/heads/master
i:
  217337: 3a24428
  217335: c5ca7dc
v: v3
  • Loading branch information
Andi Kleen committed Oct 8, 2010
1 parent 2abad5e commit 1b9dc13
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 9033ae16407f46ae06f559f9374281f6e9d89efc
refs/heads/master: a08c80ebb621a6dc277c91e029acb725f2f20254
15 changes: 1 addition & 14 deletions trunk/mm/memory-failure.c
Original file line number Diff line number Diff line change
Expand Up @@ -840,8 +840,6 @@ static int page_action(struct page_state *ps, struct page *p,
return (result == RECOVERED || result == DELAYED) ? 0 : -EBUSY;
}

#define N_UNMAP_TRIES 5

/*
* Do all that is necessary to remove user space mappings. Unmap
* the pages and send SIGBUS to the processes if the data was dirty.
Expand All @@ -853,7 +851,6 @@ static int hwpoison_user_mappings(struct page *p, unsigned long pfn,
struct address_space *mapping;
LIST_HEAD(tokill);
int ret;
int i;
int kill = 1;
struct page *hpage = compound_head(p);

Expand Down Expand Up @@ -907,17 +904,7 @@ static int hwpoison_user_mappings(struct page *p, unsigned long pfn,
if (kill)
collect_procs(hpage, &tokill);

/*
* try_to_unmap can fail temporarily due to races.
* Try a few times (RED-PEN better strategy?)
*/
for (i = 0; i < N_UNMAP_TRIES; i++) {
ret = try_to_unmap(hpage, ttu);
if (ret == SWAP_SUCCESS)
break;
pr_debug("MCE %#lx: try_to_unmap retry needed %d\n", pfn, ret);
}

ret = try_to_unmap(hpage, ttu);
if (ret != SWAP_SUCCESS)
printk(KERN_ERR "MCE %#lx: failed to unmap page (mapcount=%d)\n",
pfn, page_mapcount(hpage));
Expand Down

0 comments on commit 1b9dc13

Please sign in to comment.