Skip to content

Commit

Permalink
driver core fixes: bus_add_attrs() retval check
Browse files Browse the repository at this point in the history
Check return value of bus_add_attrs() in bus_register().

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Cornelia Huck authored and Greg Kroah-Hartman committed Oct 18, 2006
1 parent f0e1761 commit 1bb6881
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/base/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -732,11 +732,15 @@ int bus_register(struct bus_type * bus)

klist_init(&bus->klist_devices, klist_devices_get, klist_devices_put);
klist_init(&bus->klist_drivers, NULL, NULL);
bus_add_attrs(bus);
retval = bus_add_attrs(bus);
if (retval)
goto bus_attrs_fail;

pr_debug("bus type '%s' registered\n", bus->name);
return 0;

bus_attrs_fail:
kset_unregister(&bus->drivers);
bus_drivers_fail:
kset_unregister(&bus->devices);
bus_devices_fail:
Expand Down

0 comments on commit 1bb6881

Please sign in to comment.