Skip to content

Commit

Permalink
[media] drxk: fix warning: ‘status’ may be used uninitialized in this…
Browse files Browse the repository at this point in the history
… function

One of the problems of the old CHECK_ERROR is that it was hiding
the status parameter. Maybe due to that, on a few places, the return
code might lead to return incorrect status:

drivers/media/dvb/frontends/drxk_hard.c: In function ‘load_microcode.clone.0’:
drivers/media/dvb/frontends/drxk_hard.c:1281: warning: ‘status’ may be used uninitialized in this function
drivers/media/dvb/frontends/drxk_hard.c:1281: note: ‘status’ was declared here
drivers/media/dvb/frontends/drxk_hard.c: In function ‘GetLockStatus’:
drivers/media/dvb/frontends/drxk_hard.c:1792: warning: ‘status’ may be used uninitialized in this function
drivers/media/dvb/frontends/drxk_hard.c: In function ‘Start.clone.7’:
drivers/media/dvb/frontends/drxk_hard.c:1734: warning: ‘status’ may be used uninitialized in this function

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Jul 27, 2011
1 parent e16cede commit 1bd09dd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/media/dvb/frontends/drxk_hard.c
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,7 @@ static int DownloadMicrocode(struct drxk_state *state,
u16 BlockCRC;
u32 offset = 0;
u32 i;
int status;
int status = 0;

/* down the drain (we don care about MAGIC_WORD) */
Drain = (pSrc[0] << 8) | pSrc[1];
Expand Down Expand Up @@ -1731,7 +1731,7 @@ static int SetOperationMode(struct drxk_state *state,
static int Start(struct drxk_state *state, s32 offsetFreq,
s32 IntermediateFrequency)
{
int status;
int status = 0;

do {
u16 IFreqkHz;
Expand Down Expand Up @@ -1789,7 +1789,7 @@ static int ShutDown(struct drxk_state *state)
static int GetLockStatus(struct drxk_state *state, u32 *pLockStatus,
u32 Time)
{
int status;
int status = 0;

if (pLockStatus == NULL)
return -1;
Expand Down

0 comments on commit 1bd09dd

Please sign in to comment.