Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 72719
b: refs/heads/master
c: 140a748
h: refs/heads/master
i:
  72717: 3789a01
  72715: 84fceff
  72711: 9216a90
  72703: 95b9ede
v: v3
  • Loading branch information
Auke Kok authored and Jeff Garzik committed Oct 29, 2007
1 parent 3807292 commit 1c00449
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: df762464ad0fad721f9fc5724e85b3df0d550acd
refs/heads/master: 140a74802894e9db57e5cd77ccff77e590ece5f3
19 changes: 6 additions & 13 deletions trunk/drivers/net/e1000e/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,6 @@ static bool e1000_clean_rx_irq(struct e1000_adapter *adapter,
goto next_desc;
}

/* adjust length to remove Ethernet CRC */
length -= 4;

/* probably a little skewed due to removing CRC */
total_rx_bytes += length;
total_rx_packets++;

Expand Down Expand Up @@ -964,8 +960,7 @@ static bool e1000_clean_rx_irq_ps(struct e1000_adapter *adapter,
kunmap_atomic(vaddr, KM_SKB_DATA_SOFTIRQ);
pci_dma_sync_single_for_device(pdev, ps_page->dma,
PAGE_SIZE, PCI_DMA_FROMDEVICE);
/* remove the CRC */
l1 -= 4;

skb_put(skb, l1);
goto copydone;
} /* if */
Expand All @@ -987,10 +982,6 @@ static bool e1000_clean_rx_irq_ps(struct e1000_adapter *adapter,
skb->truesize += length;
}

/* strip the ethernet crc, problem is we're using pages now so
* this whole operation can get a little cpu intensive */
pskb_trim(skb, skb->len - 4);

copydone:
total_rx_bytes += skb->len;
total_rx_packets++;
Expand Down Expand Up @@ -2034,9 +2025,11 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)

ew32(RFCTL, rfctl);

/* disable the stripping of CRC because it breaks
* BMC firmware connected over SMBUS */
rctl |= E1000_RCTL_DTYP_PS /* | E1000_RCTL_SECRC */;
/* Enable Packet split descriptors */
rctl |= E1000_RCTL_DTYP_PS;

/* Enable hardware CRC frame stripping */
rctl |= E1000_RCTL_SECRC;

psrctl |= adapter->rx_ps_bsize0 >>
E1000_PSRCTL_BSIZE0_SHIFT;
Expand Down

0 comments on commit 1c00449

Please sign in to comment.