Skip to content

Commit

Permalink
ASoC: Shutdown DAPM contexts when removing a card
Browse files Browse the repository at this point in the history
Currently when a ASoC sound card is unregistered we leave the individual
components in their current state, just call the remove() callback and leave
it to the drivers to do the proper shutdown/cleanup.

This patch introduces a call to snd_soc_dapm_shutdown() when removing the
card.  This will make sure that all DAPM widgets are properly powered down
and all DAPM contexts are put at the SND_SOC_BIAS_OFF level. This will
ensure that all components are properly powered down when the card is
removed.

Since a lot of drivers manually go to SND_SOC_BIAS_OFF in their remove
callback this will also allow us to remove a bit of duplicated code.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Sep 4, 2014
1 parent 01e0df6 commit 1c325f7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/soc/soc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3812,6 +3812,7 @@ int snd_soc_unregister_card(struct snd_soc_card *card)
{
if (card->instantiated) {
card->instantiated = false;
snd_soc_dapm_shutdown(card);
soc_cleanup_card_resources(card);
}
dev_dbg(card->dev, "ASoC: Unregistered card '%s'\n", card->name);
Expand Down

0 comments on commit 1c325f7

Please sign in to comment.