Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 230739
b: refs/heads/master
c: dc83edd
h: refs/heads/master
i:
  230737: 12a48c6
  230735: 1b3c263
v: v3
  • Loading branch information
Mel Gorman authored and Linus Torvalds committed Jan 14, 2011
1 parent 003b635 commit 1c7663e
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 14 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 355b09c47a0cbb73b3e65a57c03f157f2e7ddb0b
refs/heads/master: dc83edd941f412e938841b4989be24aa288a1aa6
29 changes: 16 additions & 13 deletions trunk/mm/vmscan.c
Original file line number Diff line number Diff line change
Expand Up @@ -2227,15 +2227,16 @@ static bool pgdat_balanced(pg_data_t *pgdat, unsigned long balanced_pages,
}

/* is kswapd sleeping prematurely? */
static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)
static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining,
int classzone_idx)
{
int i;
unsigned long balanced = 0;
bool all_zones_ok = true;

/* If a direct reclaimer woke kswapd within HZ/10, it's premature */
if (remaining)
return 1;
return true;

/* Check the watermark levels */
for (i = 0; i < pgdat->nr_zones; i++) {
Expand All @@ -2256,7 +2257,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)
}

if (!zone_watermark_ok_safe(zone, order, high_wmark_pages(zone),
0, 0))
classzone_idx, 0))
all_zones_ok = false;
else
balanced += zone->present_pages;
Expand All @@ -2268,7 +2269,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)
* must be balanced
*/
if (order)
return pgdat_balanced(pgdat, balanced, 0);
return pgdat_balanced(pgdat, balanced, classzone_idx);
else
return !all_zones_ok;
}
Expand All @@ -2295,7 +2296,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining)
* of pages is balanced across the zones.
*/
static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
int classzone_idx)
int *classzone_idx)
{
int all_zones_ok;
unsigned long balanced;
Expand Down Expand Up @@ -2358,6 +2359,7 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
if (!zone_watermark_ok_safe(zone, order,
high_wmark_pages(zone), 0, 0)) {
end_zone = i;
*classzone_idx = i;
break;
}
}
Expand Down Expand Up @@ -2451,12 +2453,12 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
* spectulatively avoid congestion waits
*/
zone_clear_flag(zone, ZONE_CONGESTED);
if (i <= classzone_idx)
if (i <= *classzone_idx)
balanced += zone->present_pages;
}

}
if (all_zones_ok || (order && pgdat_balanced(pgdat, balanced, classzone_idx)))
if (all_zones_ok || (order && pgdat_balanced(pgdat, balanced, *classzone_idx)))
break; /* kswapd: all done */
/*
* OK, kswapd is getting into trouble. Take a nap, then take
Expand Down Expand Up @@ -2485,7 +2487,7 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
* high-order: Balanced zones must make up at least 25% of the node
* for the node to be balanced
*/
if (!(all_zones_ok || (order && pgdat_balanced(pgdat, balanced, classzone_idx)))) {
if (!(all_zones_ok || (order && pgdat_balanced(pgdat, balanced, *classzone_idx)))) {
cond_resched();

try_to_freeze();
Expand Down Expand Up @@ -2546,10 +2548,11 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
* if another caller entered the allocator slow path while kswapd
* was awake, order will remain at the higher level
*/
*classzone_idx = end_zone;
return order;
}

static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
static void kswapd_try_to_sleep(pg_data_t *pgdat, int order, int classzone_idx)
{
long remaining = 0;
DEFINE_WAIT(wait);
Expand All @@ -2560,7 +2563,7 @@ static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE);

/* Try to sleep for a short interval */
if (!sleeping_prematurely(pgdat, order, remaining)) {
if (!sleeping_prematurely(pgdat, order, remaining, classzone_idx)) {
remaining = schedule_timeout(HZ/10);
finish_wait(&pgdat->kswapd_wait, &wait);
prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE);
Expand All @@ -2570,7 +2573,7 @@ static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
* After a short sleep, check if it was a premature sleep. If not, then
* go fully to sleep until explicitly woken up.
*/
if (!sleeping_prematurely(pgdat, order, remaining)) {
if (!sleeping_prematurely(pgdat, order, remaining, classzone_idx)) {
trace_mm_vmscan_kswapd_sleep(pgdat->node_id);

/*
Expand Down Expand Up @@ -2658,7 +2661,7 @@ static int kswapd(void *p)
order = new_order;
classzone_idx = new_classzone_idx;
} else {
kswapd_try_to_sleep(pgdat, order);
kswapd_try_to_sleep(pgdat, order, classzone_idx);
order = pgdat->kswapd_max_order;
classzone_idx = pgdat->classzone_idx;
pgdat->kswapd_max_order = 0;
Expand All @@ -2675,7 +2678,7 @@ static int kswapd(void *p)
*/
if (!ret) {
trace_mm_vmscan_kswapd_wake(pgdat->node_id, order);
order = balance_pgdat(pgdat, order, classzone_idx);
order = balance_pgdat(pgdat, order, &classzone_idx);
}
}
return 0;
Expand Down

0 comments on commit 1c7663e

Please sign in to comment.