Skip to content

Commit

Permalink
crypto: sanitize argument for format string
Browse files Browse the repository at this point in the history
The template lookup interface does not provide a way to use format
strings, so make sure that the interface cannot be abused accidentally.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Kees Cook authored and Linus Torvalds committed Jul 3, 2013
1 parent ffc8b30 commit 1c8fca1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion crypto/algapi.c
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ static struct crypto_template *__crypto_lookup_template(const char *name)

struct crypto_template *crypto_lookup_template(const char *name)
{
return try_then_request_module(__crypto_lookup_template(name), name);
return try_then_request_module(__crypto_lookup_template(name), "%s",
name);
}
EXPORT_SYMBOL_GPL(crypto_lookup_template);

Expand Down

0 comments on commit 1c8fca1

Please sign in to comment.