Skip to content

Commit

Permalink
Inhibit NMI watchdog when Alt-SysRq-T operation is underway
Browse files Browse the repository at this point in the history
On large memory configuration with not so fast CPUs the NMI watchdog is
triggered when memory addresses are being gathered and printed.  The code
paths for Alt-SysRq-t are sprinkled with touch_nmi_watchdog in various
places but not in this routine (or in the loop that utilizes this
function).  The patch has been tested for regression on large CPU+memory
configuration (128 logical CPUs + 224 GB) and 1,2,4,16-CPU sockets with
various memory sizes (1,2,4,6,20).

Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Konrad Rzeszutek authored and Linus Torvalds committed Jul 17, 2007
1 parent 2a41de4 commit 1c978b9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/x86_64/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ static int print_trace_stack(void *data, char *name)

static void print_trace_address(void *data, unsigned long addr)
{
touch_nmi_watchdog();
printk_address(addr);
}

Expand Down

0 comments on commit 1c978b9

Please sign in to comment.